Skip to content
Snippets Groups Projects

F entity permissions

Merged Florian Spreckelsen requested to merge f-entity-permissions into dev
All threads resolved!

Summary

Prerequisite for caosdb-webui-acm#1. Moves the entity ACL functions and classes from the ACM repo to here.

Focus

Basically nothing new, just copied from other repo.

Test Environment

Unfortunately requires quite a bit of manual testing. Test by building and running the ACM module in f-entity-permissions branch.

  1. Run npm pack in this repo
  2. In caosdb-webui-acm run npm run build to build the package
  3. Take your favorite LinkAhead profile with envoy_enabled: true and copy the contents of the above build directory to profile/custom/caosdb-server/caosdb-webui/src/ext/include/acm
  4. Start LinkAhead with that profile and access localhost:8081/webinterface/acm (or whatever port your envoy config serves the webinterface)
  5. Verify that everything works as before (note that there is still the known bug of unkown server errors when updating entities/roles/... This is not part of this review)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • Reference related issues
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Florian Spreckelsen requested review from @timm

    requested review from @timm

  • Timm Fitschen resolved all threads

    resolved all threads

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Timm Fitschen approved this merge request

    approved this merge request

  • mentioned in commit eb4b9820

  • Please register or sign in to reply
    Loading