F entity permissions
Summary
Prerequisite for https://gitlab.indiscale.com/caosdb/src/caosdb-webui-acm/-/issues/1. Moves the entity ACL functions and classes from the ACM repo to here.
Focus
Basically nothing new, just copied from other repo.
Test Environment
Unfortunately requires quite a bit of manual testing. Test by building and running the ACM module in f-entity-permissions
branch.
- Run
npm pack
in this repo - In caosdb-webui-acm run
npm run build
to build the package - Take your favorite LinkAhead profile with
envoy_enabled: true
and copy the contents of the abovebuild
directory toprofile/custom/caosdb-server/caosdb-webui/src/ext/include/acm
- Start LinkAhead with that profile and access localhost:8081/webinterface/acm (or whatever port your envoy config serves the webinterface)
- Verify that everything works as before (note that there is still the known bug of unkown server errors when updating entities/roles/... This is not part of this review)
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
Reference related issues -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen