Fix large integer queries
Summary
This MR does two things:
- Fix https://gitlab.com/caosdb/caosdb-server/-/issues/145
- Expose some internals of
POV.javafor unittests.
Please merge together with caosdb-pyinttest!35 (merged)
Focus
- Was the cast to integer necessary before?
- Was the required dot in Doubles necessary before?
Test Environment
Unit tests, integration tests.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues #239 (closed) -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen
Merge request reports
Activity
assigned to @daniel
added 1 commit
- 3063dbac - MAINT: Removed debugging output and commented code.
requested review from @timm
removed review request for @timm
142 144 unitStr = m.group(2); 143 145 144 146 this.vDouble = Double.parseDouble(vDoubleStr); 145 if (this.vDouble % 1 == 0) { 146 this.vInt = (int) Math.floor(this.vDouble); changed this line in version 5 of the diff
505 507 return ret; 506 508 } 507 509 510 /** Return the value type as string, for debugging puposes. */ changed this line in version 6 of the diff
requested review from @salexan
added 6 commits
-
92f7dcb4...bc7f40b4 - 5 commits from branch
dev - 3078643a - Merge remote-tracking branch 'origin/dev' into f-fix-145-large-integer
-
92f7dcb4...bc7f40b4 - 5 commits from branch
Please register or sign in to reply