Skip to content
Snippets Groups Projects

Add tests for https://gitlab.com/caosdb/caosdb-server/-/issues/145

Merged Add tests for https://gitlab.com/caosdb/caosdb-server/-/issues/145
f-fix-145-large-integer into dev
1 unresolved thread
Merged Timm Fitschen requested to merge f-fix-145-large-integer into dev
1 unresolved thread

Summary

Tests for caosdb-server!62 (merged) (https://gitlab.com/caosdb/caosdb-server/-/issues/145) and also https://gitlab.com/caosdb/caosdb-server/-/issues/147

Please merge together with caosdb-server!62 (merged)

Focus

The MR caosdb-server!62 (merged) proposed to remove the "casting to integer". These tests show that that would be a bug and also test the fix for https://gitlab.com/caosdb/caosdb-server/-/issues/145

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #24683 passed

Stage: info
Stage: setup
Stage: cert
Stage: style
Stage: test

Pipeline passed for 64310b9d on f-fix-145-large-integer

Approved by
Daniel Hornung Timm Fitschen

Merged by Timm FitschenTimm Fitschen 2 years ago (Jun 29, 2022 9:22am UTC)

Merge details

  • Changes merged into dev with 7073a58c.
  • Deleted the source branch.

Pipeline #25075 failed

Stage: info
Stage: cert
Stage: style
Stage: test
Stage: deploy

Pipeline failed for 7073a58c on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
tests/test_issues_server.py
862
863 db.RecordType("TestRT").insert()
864 rec1 = db.Record("TestRec1").add_parent("TestRT").add_property("TestPropInt", 1_000_000_000).insert()
865 assert rec1.get_property("TestPropInt").value == 1_000_000_000
866 assert isinstance(rec1.get_property("TestPropInt").value, int)
867 rec2 = db.Record("TestRec2").add_parent("TestRT").add_property("TestPropDouble", 20_000_000_000).insert()
868 assert rec2.get_property("TestPropDouble").value == 20_000_000_000
869 assert isinstance(rec2.get_property("TestPropDouble").value, float)
870
871 assert db.execute_query("FIND TestRT WITH TestProp = 1000000000", unique=True).id == rec1.id
872 assert db.execute_query("FIND TestRT WITH TestProp = 1000000000.0", unique=True).id == rec1.id
873
874 assert db.execute_query("FIND TestRT WITH TestProp > 1000000000", unique=True).id == rec2.id
875 assert db.execute_query("FIND TestRT WITH TestProp > 1000000000.0", unique=True).id == rec2.id
876
877 assert db.execute_query("FIND TestRT WITH TestProp = 20000000000", unique=True).id == rec2.id
  • Timm Fitschen
  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen added 1 commit

    added 1 commit

    • 8ce04c21 - STY: autopep8'ed test_issues_server.py

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 15ba97c7 - Partly revert "ENH: Run testenv always."

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 489fb605 - ENH: Tests for server issue #147 on gitlab.com/caosdb/caosdb-server/

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung
  • Daniel Hornung changed the description

    changed the description

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung requested review from @salexan

    requested review from @salexan

  • Daniel Hornung removed review request for @daniel

    removed review request for @daniel

  • Daniel Hornung mentioned in issue caosdb-server#239 (closed)

    mentioned in issue caosdb-server#239 (closed)

  • Daniel Hornung approved this merge request

    approved this merge request

  • Daniel Hornung mentioned in issue caosdb-server#240

    mentioned in issue caosdb-server#240

  • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen requested review from @timm

    requested review from @timm

  • Timm Fitschen assigned to @daniel

    assigned to @daniel

  • Timm Fitschen approved this merge request

    approved this merge request

  • Timm Fitschen requested review from @daniel

    requested review from @daniel

  • Timm Fitschen mentioned in commit 7073a58c

    mentioned in commit 7073a58c

  • Timm Fitschen merged

    merged

    • Please register or sign in to reply