Skip to content
Timm Fitschen requested to merge f-fix-145-large-integer into dev

Summary

Tests for caosdb-server!62 (merged) (https://gitlab.com/caosdb/caosdb-server/-/issues/145) and also https://gitlab.com/caosdb/caosdb-server/-/issues/147

Please merge together with caosdb-server!62 (merged)

Focus

The MR caosdb-server!62 (merged) proposed to remove the "casting to integer". These tests show that that would be a bug and also test the fix for https://gitlab.com/caosdb/caosdb-server/-/issues/145

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading