Add tests for https://gitlab.com/caosdb/caosdb-server/-/issues/145
Summary
Tests for caosdb-server!62 (merged) (https://gitlab.com/caosdb/caosdb-server/-/issues/145) and also https://gitlab.com/caosdb/caosdb-server/-/issues/147
Please merge together with caosdb-server!62 (merged)
Focus
The MR caosdb-server!62 (merged) proposed to remove the "casting to integer". These tests show that that would be a bug and also test the fix for https://gitlab.com/caosdb/caosdb-server/-/issues/145
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @timm
mentioned in merge request caosdb-server!62 (merged)
requested review from @daniel
862 863 db.RecordType("TestRT").insert() 864 rec1 = db.Record("TestRec1").add_parent("TestRT").add_property("TestPropInt", 1_000_000_000).insert() 865 assert rec1.get_property("TestPropInt").value == 1_000_000_000 866 assert isinstance(rec1.get_property("TestPropInt").value, int) 867 rec2 = db.Record("TestRec2").add_parent("TestRT").add_property("TestPropDouble", 20_000_000_000).insert() 868 assert rec2.get_property("TestPropDouble").value == 20_000_000_000 869 assert isinstance(rec2.get_property("TestPropDouble").value, float) 870 871 assert db.execute_query("FIND TestRT WITH TestProp = 1000000000", unique=True).id == rec1.id 872 assert db.execute_query("FIND TestRT WITH TestProp = 1000000000.0", unique=True).id == rec1.id 873 874 assert db.execute_query("FIND TestRT WITH TestProp > 1000000000", unique=True).id == rec2.id 875 assert db.execute_query("FIND TestRT WITH TestProp > 1000000000.0", unique=True).id == rec2.id 876 877 assert db.execute_query("FIND TestRT WITH TestProp = 20000000000", unique=True).id == rec2.id -
This is fixed by caosdb-server!62 (merged)
added 1 commit
- 489fb605 - ENH: Tests for server issue #147 on gitlab.com/caosdb/caosdb-server/
requested review from @salexan
removed review request for @daniel