ENH: treat case of removed files

Summary

The move script could not deal with non-existing entities.

Test Environment

Use a path that does not exist.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

misc/move_files/move_files.py

@@ -62,8 +62,6 @@ def rename(changes, chunksize=10):
             continue
         cont = db.Container()
 
-        cmap = {}
-
         for ii, (old, new) in chunk.iterrows():
             try:
                 fi = db.File(path=old)
@@ -71,17 +69,12 @@ def rename(changes, chunksize=10):
 
                 if not fi.is_valid():
                     continue
+                assert fi.path == old
+                fi.path = new
                 cont.append(fi)
-                cmap[ii] = len(cont)-1
             except Exception as e:
                 print(e)
 
-        for ii, (old, new) in chunk.iterrows():
-            if ii not in cmap:
-                continue
-            assert cont[cmap[ii]].path == old
-            cont[cmap[ii]].path = new
-
         if len(cont) > 0:
             cont.update(unique=False)
         i += 1