Skip to content
Snippets Groups Projects

ENH: treat case of removed files

Merged Henrik tom Wörden requested to merge f-move into dev
All threads resolved!

Summary

The move script could not deal with non-existing entities.

Test Environment

Use a path that does not exist.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen requested review from @timm

    requested review from @timm

  • added 1 commit

    Compare with previous version

  • Timm Fitschen added 97 commits

    added 97 commits

    Compare with previous version

  • Timm Fitschen resolved all threads

    resolved all threads

  • Timm Fitschen added 34 commits

    added 34 commits

    Compare with previous version

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item All automated tests pass as incomplete

    marked the checklist item All automated tests pass as incomplete

  • Timm Fitschen mentioned in commit 505aa61e

    mentioned in commit 505aa61e

  • merged

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Please register or sign in to reply
    Loading