Extend Upload API for resumable downloads
Compare changes
- Joscha Schmiedt authored
@@ -86,15 +86,23 @@ enum TransmissionStatus {
@@ -116,20 +124,25 @@ message FileInformation {
@@ -142,7 +155,9 @@ message RegisterFileUploadResponse {
Related to #24. This MR changes the way how files are uploaded. The files to be uploaded are merely registered with the server, which responds with URLs, to which the files are supposed to be transmitted using the specified LinkAhead File Upload Protocol Version. This enables using the TUS protocol for uploading files via HTTPS.
There are two open questions where a decision should be made (marked in the proto files with TODO
)
FileInformation
message in the file transmission API is very similar to the FileDescriptor
message in the entity API with the
difference that it has no relation to an entity and is purely filesystem-oriented. Maybe we should re-use FileInformation s part of the entity API?Checksum
and ChecksumAlgorithm
of the file transmission API are very similar to the Hash
message in the entity API. We should discuss
if and how they can be merged.How to set up a test environment for manual testing?
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.