ENH: add the 'add_prefix' argument
-
Review changes -
-
Download -
Patches
-
Plain diff
Summary
Look at this after !100 (merged) is merged
In order to allow inserting files below some prefix (e.g. "/ExperimentalData") in the CaosDB file system, the "add_prefix" is added.
Focus
For consistency, the old "prefix" is removed and replaced by "remove_prefix"
Test Environment
There is an integration test. Test the deprication manually.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Compare and
- version 191919ee6b
- version 1801329a91
- version 17c21d2b89
- version 16e12ede01
- version 1568b91790
- version 142123b1cb
- version 136be1fa9c
- version 1217724e12
- version 1169af66cc
- version 10edfa9f56
- version 9269e3f49
- version 872f0dde3
- version 772f0dde3
- version 60035e11d
- version 50035e11d
- version 4364cd5ad
- version 3e2b47e64
- version 22a47d155
- version 1f9ae5c03
- dev (base)
- latest versionbaa032a819 commits,
- version 191919ee6b18 commits,
- version 1801329a9117 commits,
- version 17c21d2b8917 commits,
- version 16e12ede0116 commits,
- version 1568b9179015 commits,
- version 142123b1cb14 commits,
- version 136be1fa9c13 commits,
- version 1217724e1212 commits,
- version 1169af66cc11 commits,
- version 10edfa9f5610 commits,
- version 9269e3f499 commits,
- version 872f0dde38 commits,
- version 772f0dde38 commits,
- version 60035e11d7 commits,
- version 50035e11d14 commits,
- version 4364cd5ad13 commits,
- version 3e2b47e6410 commits,
- version 22a47d1558 commits,
- version 1f9ae5c037 commits,
Compare changes
- Side-by-side
- Inline
Files
7Loading