Skip to content
Snippets Groups Projects

ENH: add the 'add_prefix' argument

Merged Henrik tom Wörden requested to merge f-prefix into dev

Summary

Look at this after !100 (merged) is merged

In order to allow inserting files below some prefix (e.g. "/ExperimentalData") in the CaosDB file system, the "add_prefix" is added.

Focus

For consistency, the old "prefix" is removed and replaced by "remove_prefix"

Test Environment

There is an integration test. Test the deprication manually.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Henrik tom Wörden changed the description

    changed the description

  • added 1 commit

    • 2a47d155 - FIX: simple use case int test

    Compare with previous version

  • Henrik tom Wörden requested review from @florian

    requested review from @florian

  • added 2 commits

    • eda2e9fa - FIX: use case simple int test
    • e2b47e64 - Merge branch 'f-real-path' into f-prefix

    Compare with previous version

  • added 3 commits

    • 22b23b25 - MAINT: change from '_' to '.'
    • 75548ffe - DOC: update documentation _->.
    • 364cd5ad - Merge branch 'f-real-path' into f-prefix

    Compare with previous version

  • Henrik tom Wörden changed title from ENH: add a decorator that adds a path variable to ENH: add the 'add_prefix' argument

    changed title from ENH: add a decorator that adds a path variable to ENH: add the 'add_prefix' argument

  • added 1 commit

    • 0035e11d - MAINT: change from '_' to '.'

    Compare with previous version

  • Florian Spreckelsen changed target branch from dev to f-real-path

    changed target branch from dev to f-real-path

  • added 4 commits

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading