Skip to content
Snippets Groups Projects

ENH: add a decorator that adds a path variable

Merged Henrik tom Wörden requested to merge f-real-path into dev
All threads resolved!

Summary

file system related structure elements can use it to have a variable that can be accessed in the cfood that contains the file system path of the structure element

Also, did some refactoring of the related StructureElements

Focus

The new decorator.

I enhanced the docs quite a bit, but there is still much to do...

Test Environment

Added a unit test. Adopted an integration test

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues https://gitlab.indiscale.com/caosdb/customers/umg/management/-/issues/43
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden requested review from @henrik

    requested review from @henrik

  • Henrik tom Wörden requested review from @salexan and removed review request for @henrik

    requested review from @salexan and removed review request for @henrik

  • added 1 commit

    Compare with previous version

  • Henrik tom Wörden mentioned in merge request !101 (merged)

    mentioned in merge request !101 (merged)

  • Henrik tom Wörden requested review from @florian

    requested review from @florian

  • added 1 commit

    • eda2e9fa - FIX: use case simple int test

    Compare with previous version

  • Florian Spreckelsen removed review request for @salexan

    removed review request for @salexan

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • added 1 commit

    • 22b23b25 - MAINT: change from '_' to '.'

    Compare with previous version

  • added 1 commit

    • 75548ffe - DOC: update documentation _->.

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • added 1 commit

    • ec9a3298 - DOC: Mention PyPi package in INSTALL.md

    Compare with previous version

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • added 1 commit

    • af37656f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • b7f26e00 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Henrik tom Wörden enabled an automatic merge when the pipeline for b7f26e00 succeeds

    enabled an automatic merge when the pipeline for b7f26e00 succeeds

  • mentioned in commit 6f3717df

  • Please register or sign in to reply
    Loading