BUG: remove FixValue, fix linting errors, move and complete get_status_description

Summary

Client-side fix (or rather clean-up) of caosdb-server#169 (closed).

This MR removes the FixValue work-around (which is needed until caosdb-server!27 (merged)) and adds the missing grpc::StatusCode mappings to caosdb::StatusCode (unrelated to caosdb-server!27 (merged), but it was convenient for debugging to do this now).

Additionally, it fixes some linter warnings in ccaosdb.

Focus

• Implementation of get_status_description moved from "transaction.cpp" to "status_code_description.cpp".
• FixValue and FixValueImpl have been removed.
• Nothing needed to be done here for the fix of the unit problems (#10 (closed))

Test Environment

• Integration tests in caosdb-cppinttest!13 (merged) for both #10 (closed) and caosdb-server#169 (closed)
• No manual testing needed I'd say

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosdb/status_code_description.cpp

@@ -53,7 +53,7 @@ namespace caosdb {
 auto get_status_description(int code) -> const std::string & {
   static const std::string MISSING_DESCRIPTION = "MISSING DESCRIPTION";
   static const std::map<int, std::string> descriptions = {
-    {StatusCode::INITIAL, "The transaction has just been intialized. It has not been executed yet "
+    {StatusCode::INITIAL, "The transaction has just been initialized. It has not been executed yet "
                           "and clients can still change it and add sub-transactions."},
     {StatusCode::GO_ON, "The transaction has a transaction_type yet and clients may add matching "
                         "sub-transaction or execute it right-away."},
@@ -61,7 +61,7 @@ auto get_status_description(int code) -> const std::string & {
     {StatusCode::EXECUTING, "The transaction is currently being executed."},
     {StatusCode::SUCCESS, "The action was successful"},
 
-    {StatusCode::CANCELLED, "The operation was cancelled (typically by the caller)."},
+    {StatusCode::CANCELLED, "The operation was canceled (typically by the caller)."},
     {StatusCode::UNKNOWN, "Unknown error. This is typically a bug (server or client)."},
     {StatusCode::INVALID_ARGUMENT,
      "Client specified an invalid argument. Note that this differs from FAILED_PRECONDITION. "
@@ -142,7 +142,7 @@ auto get_status_description(int code) -> const std::string & {
      "The attempt to update this entity failed because this entity does not "
      "have "
      "an id. This is the case when you did not retrieve it before applying any "
-     "changes and instantiated the Entity class explicitely."},
+     "changes and instantiated the Entity class explicitly."},
     {StatusCode::NOT_A_FILE_ENTITY, "You can only add files to file entities."},
     {StatusCode::PATH_IS_A_DIRECTORY, "The given path is a directory."},
     {StatusCode::FILE_DOES_NOT_EXIST_LOCALLY,
@@ -168,3 +168,5 @@ auto get_status_description(int code) -> const std::string & {
 }
 
 } // namespace caosdb
+
+//  LocalWords:  ConnectionManager Extern