BUG: remove FixValue, fix linting errors, move and complete get_status_description
Summary
Client-side fix (or rather clean-up) of caosdb-server#169 (closed).
This MR removes the FixValue
work-around (which is needed until caosdb-server!27 (merged)) and adds the missing grpc::StatusCode mappings to caosdb::StatusCode (unrelated to caosdb-server!27 (merged), but it was convenient for debugging to do this now).
Additionally, it fixes some linter warnings in ccaosdb
.
Focus
- Implementation of
get_status_description
moved from "transaction.cpp" to "status_code_description.cpp". -
FixValue
andFixValueImpl
have been removed. - Nothing needed to be done here for the fix of the unit problems (#10 (closed))
Test Environment
- Integration tests in caosdb-cppinttest!13 (merged) for both #10 (closed) and caosdb-server#169 (closed)
- No manual testing needed I'd say
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Daniel Hornung