Skip to content
Snippets Groups Projects

BUG: remove FixValue, fix linting errors, move and complete get_status_description

Merged Timm Fitschen requested to merge f-value-and-unit into dev
All threads resolved!

Summary

Client-side fix (or rather clean-up) of caosdb-server#169 (closed).

This MR removes the FixValue work-around (which is needed until caosdb-server!27 (merged)) and adds the missing grpc::StatusCode mappings to caosdb::StatusCode (unrelated to caosdb-server!27 (merged), but it was convenient for debugging to do this now).

Additionally, it fixes some linter warnings in ccaosdb.

Focus

  • Implementation of get_status_description moved from "transaction.cpp" to "status_code_description.cpp".
  • FixValue and FixValueImpl have been removed.
  • Nothing needed to be done here for the fix of the unit problems (#10 (closed))

Test Environment

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen requested review from @daniel

    requested review from @daniel

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    • 4c4ac8b9 - MAINT: Spell checker found a few typos.

    Compare with previous version

  • Daniel Hornung approved this merge request

    approved this merge request

  • Daniel Hornung mentioned in commit 9e931d2b

    mentioned in commit 9e931d2b

  • Please register or sign in to reply
    Loading