Skip to content
Snippets Groups Projects

f inspect xfail

Merged Alexander Kreft requested to merge f-inspect-xfail into dev
All threads resolved!

Summary

The reason for the xfailed tests were enhanced with the issue numbers of newly created issues. A xfail which was not necessary anymore was removed.

See #30 (closed) , #51 (closed) and #52 (closed)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Kreft changed the description

    changed the description

  • Alexander Kreft marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • assigned to @florian

  • Alexander Kreft requested review from @florian

    requested review from @florian

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as incomplete

    marked the checklist item All automated tests pass as incomplete

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen enabled an automatic merge when the pipeline for 06112aa1 succeeds

    enabled an automatic merge when the pipeline for 06112aa1 succeeds

  • mentioned in commit 08e13a67

  • Please register or sign in to reply
    Loading