Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

L

LinkAhead Sample Management
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Environments
- Terraform modules
- Incidents

Snippets Groups Projects

!2

F sample name

Review changes
Download
Patches
Plain diff

Merged F sample name

f-sample-name into main

Overview 7
Commits 13
Pipelines 0
Changes 11

Merged Florian Spreckelsen requested to merge f-sample-name into main 4 weeks ago

Overview 7
Commits 13
Pipelines 0
Changes 11

Summary

For https://gitlab.indiscale.com/caosdb/customers/glaz_awi/management/-/issues/386. Introduce sample names to export and upload. Also does the sorting and renaming in https://gitlab.indiscale.com/caosdb/customers/glaz_awi/management/-/issues/378.

Focus

There is new special treatment for sample names (which is needed since name is not a regular property).

Test Environment

Run the test profile, then play around with exporting and uploading samples with names, e.g.,

Give a name to a sample entity via the edit mode and verify that it is exported correctly
register samples and select sample name as additional column. Fill with value and upload. Verify that the names have been updated.
Export a sample. Change the name, upload again, and verify that the name has been set.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

All automated tests pass
Reference related issues
Up-to-date CHANGELOG.md (or not necessary)
Up-to-date JSON schema (or not necessary)
Appropriate user and developer documentation (or not necessary)
- How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
Annotations in code (Gitlab comments)
- Intent of new code
- Problems with old code
- Why this implementation?

Check List for the Reviewer

I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md (or not necessary)
Appropriate user and developer documentation (or not necessary)
The test environment setup works and the intended behavior is reproducible in the test environment
In-code documentation and comments are up-to-date.
Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited 4 weeks ago by Florian Spreckelsen

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

0 Reviewers

Request review from

Loading

Labels

0

None

0

None

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

0

0 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.

Loading