Skip to content

F sample name

Florian Spreckelsenrequested to merge
f-sample-name into main

Summary

For https://gitlab.indiscale.com/caosdb/customers/glaz_awi/management/-/issues/386. Introduce sample names to export and upload. Also does the sorting and renaming in https://gitlab.indiscale.com/caosdb/customers/glaz_awi/management/-/issues/378.

Focus

There is new special treatment for sample names (which is needed since name is not a regular property).

Test Environment

Run the test profile, then play around with exporting and uploading samples with names, e.g.,

  • Give a name to a sample entity via the edit mode and verify that it is exported correctly
  • register samples and select sample name as additional column. Fill with value and upload. Verify that the names have been updated.
  • Export a sample. Change the name, upload again, and verify that the name has been set.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports