Skip to content

fix form_elements dropdow menu (deselect all)

Timm Fitschen requested to merge f-fix-212 into f-boot-tour

Summary

This MR provides a fix for #212 (closed) (supposedly) and another AWI bug (caosdb/customers/glaz_awi/management#210).

Focus

Apparently, the API of bootstrap-select changed since 1.13.9 (which we were using prior to the bootstrap-5 update) or we didn't use the documented API to achieve what we were doing.

Now, the relevant code for clicking the deselect button in form_element.js is up-to-date.

Also, I updated to a stable bootstrap 5 release and made some adjustments to styling of rows in the forms generated by form_elements while I was at it.

Test Environment

  • please test this with AWI

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports