Skip to content
Snippets Groups Projects

add merge_js.sh script

Merged add merge_js.sh script
f-combine-js-files into f-boot-tour
Merged Timm Fitschen requested to merge f-combine-js-files into f-boot-tour

Summary

Concatenates all js files into public/webcaosdb.dist.js. The correct order is to be specified in the build variable MODULE_DEPENDENCIES. All files which are not in that array will be appended randomly.

fixes #152 (closed)

Focus

Most of the work is done in misc/merge_js.sh. It is called in the Makefile in a special make target.

Test Environment

Test locally with make or start any linkahead docker with this branch.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #7551 passed with warnings

Stage: linting
Stage: test
Stage: deploy
Pipeline: LinkAhead

#7552

    Pipeline passed with warnings for 5eaa6ec2 on f-combine-js-files

    Approval is optional

    Merged by Florian SpreckelsenFlorian Spreckelsen 3 years ago (May 12, 2021 1:58pm UTC)

    Loading

    Pipeline #7591 passed with warnings

    Stage: linting
    Stage: test
    Stage: deploy
    Pipeline: LinkAhead

    #7592

      Pipeline passed with warnings for 48933d81 on f-boot-tour

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      Please register or sign in to reply