Skip to content

F 344 extern linkify absorbs commas etc into link adress

Summary

The cosmetics.linkify module has been changed to be more robust when detecting URLs. This addresses in particular issue #344 (closed), but now also correctly handles ports.

This merge request also adds some more info on running the unit tests, in particular adding dependencies and info on WSL (#346 (closed)).

Focus

All important changes are in caosdb-webui/src/core/js/ext_cosmetics.js and the corresponding unit tests in coasdb-webui/test/core/js/modules/ext_cosmetics.js.js.

Test Environment

How to set up a test environment for manual testing?

See README_SETUP.md (updated in this branch).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading