FIX for #166

Summary

Fix for https://gitlab.com/caosdb/caosdb-server/-/issues/166

see also #255 (closed)

Focus

The bug was a corner case of the inheritance job when the parent did not exist. The existence of the parent has been checked a few lines above (and a non-existing parent has EntityState == UNQUALIFIED). But we need to check the QUALIFIEDness here again of course.

Test Environment

No manual testing required. caosdb-pyinttest!58 (merged)

Check List for the Author

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)

For further good practices have a look at our review guidelines.

src/main/java/org/caosdb/server/jobs/core/Inheritance.java

@@ -119,7 +119,7 @@ public class Inheritance extends EntityJob {
       }
 
       // implement properties
-      if (getEntity().hasProperties()) {
+      if (getEntity().getEntityStatus() == EntityStatus.QUALIFIED && getEntity().hasProperties()) {
         propertyLoop:
         for (final Property property : getEntity().getProperties()) {
           final ArrayList<Property> transfer = new ArrayList<>();
@@ -140,9 +140,6 @@ public class Inheritance extends EntityJob {
             if (getEntity().hasParents()) {
               outer:
               for (EntityInterface par : getEntity().getParents()) {
-                if (par.getEntityStatus() == EntityStatus.UNQUALIFIED) {
-                  continue;
-                }
                 if (!par.hasProperties()) {
                   par = resolve(par);
                 }