Skip to content
Snippets Groups Projects

FIX for #166

Merged Timm Fitschen requested to merge f-issue-166 into dev
All threads resolved!

Summary

Fix for https://gitlab.com/caosdb/caosdb-server/-/issues/166

see also #255 (closed)

Focus

The bug was a corner case of the inheritance job when the parent did not exist. The existence of the parent has been checked a few lines above (and a non-existing parent has EntityState == UNQUALIFIED). But we need to check the QUALIFIEDness here again of course.

Test Environment

No manual testing required. caosdb-pyinttest!58 (merged)

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen requested review from @henrik

    requested review from @henrik

  • Timm Fitschen changed the description

    changed the description

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • mentioned in commit 4988aa3f

  • Please register or sign in to reply
    Loading