FIX for #166
All threads resolved!
All threads resolved!
Summary
Fix for https://gitlab.com/caosdb/caosdb-server/-/issues/166
see also #255 (closed)
Focus
The bug was a corner case of the inheritance job when the parent did not exist. The existence of the parent has been checked a few lines above (and a non-existing parent has EntityState == UNQUALIFIED). But we need to check the QUALIFIEDness here again of course.
Test Environment
No manual testing required. caosdb-pyinttest!58 (merged)
Check List for the Author
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments)
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary)
For further good practices have a look at our review guidelines.
Edited by Henrik tom Wörden
Merge request reports
Activity
assigned to @timm
mentioned in merge request caosdb-pyinttest!58 (merged)
mentioned in issue #255 (closed)
- Resolved by Henrik tom Wörden
requested review from @henrik
mentioned in commit 4988aa3f
Please register or sign in to reply