F find query
-
Review changes -
-
Download -
Patches
-
Plain diff
Attention: f06ca944 must be checked carefully. Two separate changes affected the "WITH" statement. @daniel can you help/check?
Summary
The default behavior of the query FIND SomeName [...]
(as well as COUNT
and SELECT
) is being made configurable and changes
-
FIND SomeName
will be interpreted asFIND $FIND_QUERY_DEFAULT_ROLE SomeName
from now on whereFIND_QUERY_DEFAULT_ROLE
is a newly introduced server property. - The new
FIND_QUERY_DEFAULT_ROLE
server property defaults toRECORD
which is why the behavior of the server api has a breaking change. - Of course, administrators can choose to retain the old behavior by setting
FIND_QUERY_DEFAULT_ROLE=ENTITY
.
As requested per caosdb/customers/leibniz-zmt/management#98
Focus
Since the default role is configurable the changed code is executed after the parsing of the query string. This way, the parser did not change at all.
Test Environment
Tests in caosdb-pyinttest!45 (merged)
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
- version 156eabb13f
- version 14f06ca944
- version 1392700d91
- version 12d456ba60
- version 11972e91ec
- version 104d15622c
- version 922ec41ba
- version 8f541bcd4
- version 7ce6c7628
- version 6c78e268c
- version 5a43f4756
- version 4e873c5b7
- version 39e35ead5
- version 258d0b78d
- version 1fb29e9a1
- dev (base)
- latest versionfe9e1a3814 commits,
- version 156eabb13f13 commits,
- version 14f06ca94412 commits,
- version 1392700d9111 commits,
- version 12d456ba6010 commits,
- version 11972e91ec9 commits,
- version 104d15622c8 commits,
- version 922ec41ba9 commits,
- version 8f541bcd48 commits,
- version 7ce6c76287 commits,
- version 6c78e268c6 commits,
- version 5a43f47565 commits,
- version 4e873c5b74 commits,
- version 39e35ead53 commits,
- version 258d0b78d2 commits,
- version 1fb29e9a11 commit,
- Side-by-side
- Inline