Skip to content
Snippets Groups Projects

F find query

Merged Timm Fitschen requested to merge f-find-query into dev

Attention: f06ca944 must be checked carefully. Two separate changes affected the "WITH" statement. @daniel can you help/check?

Summary

The default behavior of the query FIND SomeName [...] (as well as COUNT and SELECT) is being made configurable and changes

  1. FIND SomeName will be interpreted as FIND $FIND_QUERY_DEFAULT_ROLE SomeName from now on where FIND_QUERY_DEFAULT_ROLE is a newly introduced server property.
  2. The new FIND_QUERY_DEFAULT_ROLE server property defaults to RECORD which is why the behavior of the server api has a breaking change.
  3. Of course, administrators can choose to retain the old behavior by setting FIND_QUERY_DEFAULT_ROLE=ENTITY.

As requested per caosdb/customers/leibniz-zmt/management#98

Focus

Since the default role is configurable the changed code is executed after the parsing of the query string. This way, the parser did not change at all.

Test Environment

Tests in caosdb-pyinttest!45 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen requested review from @florian

    requested review from @florian

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Essentially, this looks good to me, but I suggest that FIND * translates to FIND DEFAULT_QUERY_ROLE *, not FIND ENTITY *.

  • Timm Fitschen added 1 commit

    added 1 commit

    • e873c5b7 - ENH: change behavior of FIND *

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading