Skip to content

F find query

Timm Fitschen requested to merge f-find-query into dev

Summary

  1. Tests for caosdb-server!71 (merged)
  2. Refactoring in some modules (1000 lines less!):
  • Replace nose by pytest assertions
  • Move clean-up from the test functions to setup/teardown functions.

Focus

In many cases, just the ENTITY was added to the queries for these tests to pass again. In the query related test modules, a simpler approach has been taken and the new server option FIND_QUERY_DEFAULT_ROLE was set to ENTITY.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports