F 220

Summary

Fix for #220 (closed) and #223 (closed)

Focus

• Class SetFieldStrategy is being renamed to SerializeFieldStrategy in order to avoid setters and getters with awkward names: SetSetFieldStrategy and GetSetFieldStrategy.
• New special strategy for serializing entities in the case that the client is not permitted to retrieve an entity.
• The SerializeFieldStrategy is also used in the CaosdbToGrpc Helper class now. This is the actual bug fix! Prior to this, the entities would be serialized to Protobuf without any mechanism to prevent all the fields (i.e. the id, name, parents, properties...) from being serialized. This was planned anyways (because this is part of the implementation for SELECT query responses) but it didn't occur to me that this is already needed for normal retrievals.

Test Environment

For #220 (closed)

• Please test this manually with the cfaed wiki.
• It is currently not possible to test this with cppinttest (due to a lack of ACM implementation).
• Unit tests are included here

For #223 (closed)

• See caosdb-pyinttest!31 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/main/java/org/caosdb/server/entity/container/ParentContainer.java

@@ -26,7 +26,7 @@ import org.caosdb.server.entity.Entity;
 import org.caosdb.server.entity.EntityInterface;
 import org.caosdb.server.entity.wrapper.Parent;
 import org.caosdb.server.entity.xml.ParentToElementStrategy;
-import org.caosdb.server.entity.xml.SetFieldStrategy;
+import org.caosdb.server.entity.xml.SerializeFieldStrategy;
 import org.caosdb.server.entity.xml.ToElementStrategy;
 import org.caosdb.server.utils.EntityStatus;
 import org.caosdb.server.utils.Observable;
@@ -51,10 +51,10 @@ public class ParentContainer extends Container<Parent> {
   }
 
   public Element addToElement(final Element element) {
-    final SetFieldStrategy setFieldStrategy =
-        new SetFieldStrategy(this.child.getSelections()).forProperty("parent");
+    final SerializeFieldStrategy serializeFieldStrategy =
+        new SerializeFieldStrategy(this.child.getSelections()).forProperty("parent");
     for (final EntityInterface entity : this) {
-      s.addToElement(entity, element, setFieldStrategy);
+      s.addToElement(entity, element, serializeFieldStrategy);
     }
     return element;
   }