Skip to content
Snippets Groups Projects

F 220

Merged Timm Fitschen requested to merge f-220 into dev

Summary

Fix for #220 (closed) and #223 (closed)

Focus

  • Class SetFieldStrategy is being renamed to SerializeFieldStrategy in order to avoid setters and getters with awkward names: SetSetFieldStrategy and GetSetFieldStrategy.
  • New special strategy for serializing entities in the case that the client is not permitted to retrieve an entity.
  • The SerializeFieldStrategy is also used in the CaosdbToGrpc Helper class now. This is the actual bug fix! Prior to this, the entities would be serialized to Protobuf without any mechanism to prevent all the fields (i.e. the id, name, parents, properties...) from being serialized. This was planned anyways (because this is part of the implementation for SELECT query responses) but it didn't occur to me that this is already needed for normal retrievals.

Test Environment

For #220 (closed)

  • Please test this manually with the cfaed wiki.
  • It is currently not possible to test this with cppinttest (due to a lack of ACM implementation).
  • Unit tests are included here

For #223 (closed)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as incomplete

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as incomplete

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen added 1 commit

    added 1 commit

    • efe146b3 - TST: add unit test for serialization of entities without retrieve permissions

    Compare with previous version

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading