BUG: fix for #170

Summary

Fix for #170 (closed)

The update transation still used an old and obsolete implementation for inserting values. This only affected the corner case of the issue (update of an abstract, list-type property with a non-null value (aka "default value").

Focus

• Removed obsolete class InsertEntityValue (because the value is inserted by InsertEntityProperties and the respective call in UpdateEntityTransaction.

Test Environment

• check the tests in caosdb-pyinttest!12 (merged)
• please verify that also the tests in caosdb-cppinttest@4ad86b5d are passing now

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/main/java/org/caosdb/server/database/backend/transaction/InsertEntityValue.java

-/*
- * ** header v3.0
- * This file is a part of the CaosDB Project.
- *
- * Copyright (C) 2018 Research Group Biomedical Physics,
- * Max-Planck-Institute for Dynamics and Self-Organization Göttingen
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program. If not, see <https://www.gnu.org/licenses/>.
- *
- * ** end header
- */
-package org.caosdb.server.database.backend.transaction;
-
-import org.caosdb.server.database.BackendTransaction;
-import org.caosdb.server.database.backend.interfaces.InsertEntityPropertiesImpl;
-import org.caosdb.server.database.exceptions.TransactionException;
-import org.caosdb.server.database.proto.FlatProperty;
-import org.caosdb.server.datatype.SingleValue;
-import org.caosdb.server.entity.EntityInterface;
-import org.caosdb.server.entity.StatementStatus;
-
-public class InsertEntityValue extends BackendTransaction {
-
-  private final EntityInterface entity;
-
-  public InsertEntityValue(final EntityInterface entity) {
-    this.entity = entity;
-  }
-
-  @Override
-  protected void execute() throws TransactionException {
-    final InsertEntityPropertiesImpl t = getImplementation(InsertEntityPropertiesImpl.class);
-
-    final FlatProperty p = new FlatProperty();
-    if (this.entity.hasValue()) {
-      p.id = this.entity.getId();
-      p.value = ((SingleValue) this.entity.getValue()).toDatabaseString();
-      p.status = StatementStatus.FIX.toString();
-      p.idx = 0;
-      t.execute(
-          this.entity.getDomain(),
-          this.entity.getId(),
-          p,
-          ((SingleValue) this.entity.getValue()).getTable(),
-          (this.entity.hasUnit() ? this.entity.getUnit().getSignature() : null));
-    }
-  }
-}