Skip to content

BUG: fix for #170

Timm Fitschen requested to merge f-server-170 into dev

Summary

Fix for #170 (closed)

The update transation still used an old and obsolete implementation for inserting values. This only affected the corner case of the issue (update of an abstract, list-type property with a non-null value (aka "default value").

Focus

  • Removed obsolete class InsertEntityValue (because the value is inserted by InsertEntityProperties and the respective call in UpdateEntityTransaction.

Test Environment

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports