Skip to content

add noscript hint

Timm Fitschen requested to merge f-noscript into dev

Summary

Adds a hint "Please enable JavaScript" to the server's response. This should cover the cases where even the XSL transformation is disabled.

Tests needed to be updated in caosdb-pyinttest!5 (merged)

Test Environment

Go to a browser where XSLT is disabled when JS is disabled (older FF) and disable JS. The hint should be visible

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading