Skip to content
Snippets Groups Projects
  1. Nov 10, 2020
  2. Nov 06, 2020
  3. Nov 05, 2020
  4. Nov 03, 2020
  5. Oct 21, 2020
  6. Oct 14, 2020
  7. Sep 11, 2020
  8. Sep 07, 2020
  9. Sep 03, 2020
  10. Sep 02, 2020
  11. Sep 01, 2020
  12. Aug 25, 2020
  13. Aug 24, 2020
  14. Aug 18, 2020
  15. Aug 14, 2020
  16. Aug 11, 2020
  17. Aug 10, 2020
  18. Jul 16, 2020
    • Timm Fitschen's avatar
      Merge branch 'dev' into f-versioning · a1599371
      Timm Fitschen authored
      Verified
      a1599371
    • Timm Fitschen's avatar
      Merge branch 'f-select-subproperties' into 'dev' · 30d3d3d4
      Timm Fitschen authored
      f-select-subproperties -> dev
      
      # Summary
      
      See summary of https://gitlab.com/caosdb/caosdb-webui/-/merge_requests/72
      
      Funny side note: this MR !47 and the issue it resolves #47 have the same number :grinning: 
      
      # Focus
      
      * The important changes are in `RetrieveFullEntity.java`, `EntityToElementStrategy.java` and `SetFieldStrategy.java`.
        * `RetrieveFullEntity.java` is responsible for the retrieval of entities and it needed additional functionality to retrieve referenced entities recursively. It does this but only if a list of `Query.Selects` is there and non-empty, because this is the case when the request is a SELECT query.
        * `EntityToElementStrategy.java` is responsible for the xml generation. It was kind of buggy and I did some refactoring there.
        * `SetFieldStrategy.java` is decides whether a property of an entity is to be included in the generated output (xml) or not. 
      Additional functionality is added to cope with deeply nested references.
      * Note: I also deleted the AWI stuff, because I didn't want to refactor these classes.
      
      # Test Environment
      
      See https://gitlab.com/caosdb/caosdb-webui/-/merge_requests/72
      
      # Check List for the Author
      
      - [x] All automated tests pass
      - [x] Reference related Issues
      - [x] Up-to-date CHANGELOG.md
      - [x] Annotations in code (Gitlab comments)
        - Intent of new code
        - Problems with old code
        - Why this implementation?
      
      
      # Check List for the Reviewer
      
      
      - [x] I understand the intent of this MR
      - [x] All automated tests pass
      - [x] Up-to-date CHANGELOG.md
      - [ ] The test environment setup works and the intended behavior is
        reproducible in the test environment
      - [x] In-code documentation and comments are up-to-date.
      - [ ] Check: Are there spezifications? Are they satisfied?
      
      For further good practices have a look at [our review guidelines](https://gitlab.com/caosdb/caosdb/-/blob/dev/REVIEW_GUIDELINES.md).
      
      See merge request caosdb/caosdb-server!47
      30d3d3d4
Loading