Skip to content

fix caosdb-deploy#225

Timm Fitschen requested to merge f-get-owner into dev

Summary

Fix for #225 (closed).

Focus

  • Problem was a wrong implementation of getOwners (src/main/java/org/caosdb/server/permissions/EntityACL.java).
  • On the go I also updated shiro (library for Role-Based Access Management) and simplified some of the Check* jobs.

Test Environment

New unit tests where added which test the buggy behavior. Please check failing tests with original implementation (go to dev, git checkout src/test, then make test).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading