F fix empty diff

Summary

In the course of https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/129, an error in the empty_diff function occurred when comparing entities with different ids.

Focus

apiutils.empty_diff now handles special attributes separately.

Test Environment

Unittest should be sufficient. To reproduce previous behavior for manual testing, install pylib in dev and execute

pytest -vvv unittests/test_apiutils.py::test_empty_diff

with the unit test from this branch.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosdb/apiutils.py

@@ -353,10 +353,14 @@ def empty_diff(old_entity: Entity, new_entity: Entity, compare_referenced_record
     olddiff, newdiff = compare_entities(
         old_entity, new_entity, compare_referenced_records)
     for diff in [olddiff, newdiff]:
-        for key in diff:
+        for key in ["parents", "properties"]:
             if len(diff[key]) > 0:
                 # There is a difference somewhere in the diff
                 return False
+        for key in SPECIAL_ATTRIBUTES:
+            if key in diff and diff[key]:
+                # There is a difference in at least one special attribute
+                return False
     # all elements of the two diffs were empty
     return True