Skip to content
Snippets Groups Projects

F fix empty diff

Merged Florian Spreckelsen requested to merge f-fix-empty-diff into dev

Summary

In the course of https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/129, an error in the empty_diff function occurred when comparing entities with different ids.

Focus

apiutils.empty_diff now handles special attributes separately.

Test Environment

Unittest should be sufficient. To reproduce previous behavior for manual testing, install pylib in dev and execute

pytest -vvv unittests/test_apiutils.py::test_empty_diff

with the unit test from this branch.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Pipeline #30184 passed

Pipeline: LinkAhead

#30185

    Pipeline passed for 1b2722c5 on f-fix-empty-diff

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 2 years ago (Nov 9, 2022 3:04pm UTC)

    Merge details

    • Changes merged into f-review-lists-and-compare with 3566b6b5.
    • Deleted the source branch.

    Pipeline #30220 failed

    Pipeline: LinkAhead

    #30221

      Pipeline failed for 3566b6b5 on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      Please register or sign in to reply
      Loading