F mypy

Summary

Add mypy to the GitLab CI/CD pipeline.

Focus

.gitlab-ci.yml now contains a mypy job that checks the code base for type errors. It is allowed to fail.

Test Environment

Regular setup.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

.gitlab-ci.yml

@@ -29,9 +29,9 @@ variables:
 image: $CI_REGISTRY_IMAGE
 
 stages:
+  - setup
   - code_style
   - linting
-  - setup
   - test
   - deploy
 
@@ -53,6 +53,13 @@ pylint:
     - make lint
   allow_failure: true
 
+mypy:
+  tags: [ docker ]
+  stage: linting
+  script:
+    - mypy  src/caosdb
+  allow_failure: true
+
 # run unit tests
 unittest_py3.7:
   tags: [ docker ]
@@ -126,6 +133,7 @@ build-testenv:
   stage: setup
   only:
       - schedules
+      - web
   script:
     - cd unittests/docker
     - docker login -u gitlab-ci-token -p $CI_JOB_TOKEN $CI_REGISTRY