F mypy
Summary
Add mypy
to the GitLab CI/CD pipeline.
Focus
.gitlab-ci.yml
now contains a mypy
job that checks the code base for type errors. It is allowed to fail.
Test Environment
Regular setup.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @henrik
mentioned in issue #143 (closed)
added 264 commits
-
89b132d2...94de0ce0 - 263 commits from branch
dev
- 9a857ee3 - Merge branch 'dev' into f-mypy
-
89b132d2...94de0ce0 - 263 commits from branch
assigned to @joschaschmiedt
added 99 commits
-
9a857ee3...1ecb0883 - 98 commits from branch
dev
- 541ff0ee - Merge branch 'dev' into 'f-mypy'
-
9a857ee3...1ecb0883 - 98 commits from branch
added 2 commits
@henrik, I added
python3-mypy
to the installation script in the unittestsDockerfile
. However, the GitLab job still complains thatmypy
is not there. Do you have an idea? Does the Docker image actually get rebuilt?added 1 commit
- f3c08930 - Add pip install mypy to .gitlab-ci.yml mypy job
added 1 commit
- 0c2ae1d7 - Add typing dependencies to mypy gitlab-ci job
unassigned @joschaschmiedt
@henrik, this is ready to be merged.
assigned to @joschaschmiedt and unassigned @henrik
requested review from @florian