Skip to content

FIX: JSON schema now is more permissive, and fixed if-conditions.

Daniel Hornung requested to merge f-extend-json-schema into dev

For #75 (closed), #103 (closed).

Summary

In the JSON schema:

  • Fix authentication requirements.
  • Allow more sections.

Focus

  • Is the JSON schema still correct?
  • Are all the cases covered in the tests?

Test Environment

pytest --no-cov unittests/test_schema.py

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading