FIX: JSON schema now is more permissive, and fixed if-conditions.
Merged
FIX: JSON schema now is more permissive, and fixed if-conditions.
f-extend-json-schema
into
dev
All threads resolved!
All threads resolved!
For #75 (closed), #103 (closed).
Summary
In the JSON schema:
- Fix authentication requirements.
- Allow more sections.
Focus
- Is the JSON schema still correct?
- Are all the cases covered in the tests?
Test Environment
pytest --no-cov unittests/test_schema.py
Check List for the Author
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
assigned to @daniel
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
The pipelines still do not run completely, probably because at some point they do not reference the correct pylib branch. Last attempt: also create a dummy branch with the correct name for caosdb-server.
added 1 commit
- 9e310bad - DOC: Added comment about bug in pypa/packaging<=21.3.
mentioned in commit c6aa4f94
Please register or sign in to reply