Skip to content

Revert "Revert "Merge branch 'f-validate-config' into 'dev'""

Florian Spreckelsen requested to merge f-fix-json-schema into dev

Summary

2nd attempt to merge #70 (closed) because of an unforeseen pipline error.

Focus

Please focus on the actual implementation and the setup.

Test Environment

Please test:

  • Install pylib without argument - no jsonschema installed?
  • Install pylib with pip3 install .[jsonschema] - is the correct version of jsonschema installed
  • run tox without jsonschema installed - is there a temporary installation?
  • is everything running in caosdb-deploy?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading