Skip to content
Snippets Groups Projects

Revert "Revert "Merge branch 'f-validate-config' into 'dev'""

Merged Florian Spreckelsen requested to merge f-fix-json-schema into dev

Summary

2nd attempt to merge #70 (closed) because of an unforeseen pipline error.

Focus

Please focus on the actual implementation and the setup.

Test Environment

Please test:

  • Install pylib without argument - no jsonschema installed?
  • Install pylib with pip3 install .[jsonschema] - is the correct version of jsonschema installed
  • run tox without jsonschema installed - is there a temporary installation?
  • is everything running in caosdb-deploy?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Kreft
  • Alexander Kreft
  • Alexander Kreft
  • Alexander Kreft changed the description

    changed the description

  • Alexander Kreft marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Alexander Kreft marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Alexander Kreft marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Alexander Kreft assigned to @al-kr and unassigned @florian

    assigned to @al-kr and unassigned @florian

  • Alexander Kreft requested review from @florian

    requested review from @florian

  • added 5 commits

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • added 2 commits

    • a6ff279e - ENH: Make '/' at the end of URLs in cofig optional
    • 6ce9c09e - FIX: Typo in OS name

    Compare with previous version

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading