Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

C

caosdb-pylib
- Activity
- Members
- Labels
- Environments
- Incidents

Snippets Groups Projects

!166

Detect infinite recursion in Entity.to_xml

Review changes
Download
Patches
Plain diff

Merged Detect infinite recursion in Entity.to_xml

f-bug-fit-96-print-recursion into dev

Overview 1
Commits 7
Pipelines 6
Changes 3

Merged I. Nüske requested to merge f-bug-fit-96-print-recursion into dev 3 months ago

Overview 1
Commits 7
Pipelines 6
Changes 3

Summary

Addresses https://gitlab.indiscale.com/caosdb/customers/f-fit/management/-/issues/96 / https://gitlab.com/linkahead/linkahead-pylib/-/issues/73
When calling to_xml on an Entity that refers to itself, to_xml now detects the infinite recursion and stops after the first level of repeated information.

Focus

What is the likelihood that a version refers to itself (predecessor / successor)? Do we need to add the same functionality to Version.to_xml?
Does this change anything for Entities that could already successfully call to_xml before? Are there cases where this might break the communication with the server?

Test Environment

Manual Testing

Check List for the Author

All automated tests pass
Reference related issues
Up-to-date CHANGELOG.md (or not necessary)
Up-to-date JSON schema (or not necessary)
Appropriate user and developer documentation (or not necessary)
Annotations in code (Gitlab comments)

Check List for the Reviewer

I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md (or not necessary)
Appropriate user and developer documentation (or not necessary)
The test environment setup works and the intended behavior is reproducible in the test environment
In-code documentation and comments are up-to-date.
Check: Are there specifications? Are they satisfied?

Edited 3 months ago by Florian Spreckelsen

Merge request reports

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

0

None

0

None

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

0

0 Participants

Viewing commit f202d940

Show latest version

Compare changes

Side-by-side
Inline

Show whitespace changes

Show one file at a time

Files

3

Search (e.g. *.vue) (Ctrl+P)

f202d940

BUG: Prevent infinite recursion in Entity.to_xml: · f202d940

I. Nüske authored 3 months ago

- Added a visited_entities parameter to save all Entities already treated in to_xml. New calls to to_xml are checked against this to identify potential infinite recursion
- Added test
- Updated changelog

Loading