What is the likelihood that a version refers to itself (predecessor / successor)? Do we need to add the same functionality to Version.to_xml?
Does this change anything for Entities that could already successfully call to_xml before? Are there cases where this might break the communication with the server?
Test Environment
Manual Testing
Check List for the Author
All automated tests pass
Reference related issues
Up-to-date CHANGELOG.md (or not necessary)
Up-to-date JSON schema (or not necessary)
Appropriate user and developer documentation (or not necessary)
Annotations in code (Gitlab comments)
Check List for the Reviewer
I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md (or not necessary)
Appropriate user and developer documentation (or not necessary)
The test environment setup works and the intended behavior is reproducible in the test
environment
In-code documentation and comments are up-to-date.
Check: Are there specifications? Are they satisfied?
- Added a visited_entities parameter to save all Entities already treated in to_xml. New calls to to_xml are checked against this to identify potential infinite recursion
- Added test
- Updated changelog
Florian Spreckelsen authored