FIX: compare_entities was not written for properties. raise error

Summary

#121 (closed) Remove xfail of test. This fixes two things:

• use 'importance' in the test correctly and test it correctly
• add 'value' to SPECIAL_PROPERTIES list such that it is also compared

Test Environment

pipelines

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/linkahead/common/models.py

@@ -81,7 +81,7 @@ NONE = "NONE"
 
 
 SPECIAL_ATTRIBUTES = ["name", "role", "datatype", "description",
-                      "id", "path", "checksum", "size"]
+                      "id", "path", "checksum", "size", "value"]
 
 
 class Entity:
@@ -154,7 +154,7 @@ class Entity:
         # Copy special attributes:
         # TODO: this might rise an exception when copying
         #       special file attributes like checksum and size.
-        for attribute in SPECIAL_ATTRIBUTES + ["value"]:
+        for attribute in SPECIAL_ATTRIBUTES:
             val = getattr(self, attribute)
             if val is not None:
                 setattr(new, attribute, val)