FIX: compare_entities was not written for properties. raise error

Summary

#121 (closed) Remove xfail of test. This fixes two things:

• use 'importance' in the test correctly and test it correctly
• add 'value' to SPECIAL_PROPERTIES list such that it is also compared

Test Environment

pipelines

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

assigned to @henrik

added 1 commit

• 85307e27 - FIX: broken test related to importance of property

Compare with previous version

added 1 commit

• 88552821 - MAINT: add 'value' to special properties

Compare with previous version

marked the checklist item All automated tests pass as completed

marked the checklist item Reference related issues as completed

marked the checklist item Up-to-date JSON schema (or not necessary) as completed

marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

marked the checklist item Annotations in code (Gitlab comments) as completed

requested review from @florian

changed the description

marked the checklist item I understand the intent of this MR as completed

marked the checklist item All automated tests pass as completed

marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

marked the checklist item In-code documentation and comments are up-to-date. as completed

approved this merge request

mentioned in commit 5e403633

merged