Summary

I reviewed the compare_entities function from apiutils and identified some problematic cases (e.g. multi-properties). Corresponding unit tests have been created and the functionality repaired.

This is a preparation for a comprehensive review of the merge_entities function. I think it's a good idea to merge this in a first step as it's probably independent from the review of the merge function.

Focus

This one can probably be reviewed line-by-line. Maybe look for missing test-corner-cases that might be needed. The code for checking the value for equality is still not ideal, but I think a more comprehensive review (also adding the recursive reference checker) should be postponed.

Test Environment

There are unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.