MAINT: refactor _Messages class
-
Review changes -
-
Download -
Patches
-
Plain diff
Summary
For caosdb-server#286 (closed)
- rename
_Messages
toMessages
since it is public API - change parent class to list since Multiple Messages with same type and code may occur
- deprecate lots of stuff that makes usage fuzzy (e.g. three different ways to supply arguments) and concentrate on behavior that is close to that of lists (which is what users know)
Focus
It is quite hard to figure out what the current behavior is. However, I preserved it for now and added lots of deprecation warnings.
Test Environment
unit and int test
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen
Merge request reports
Compare and
- version 172fa947f0
- version 16f9fa25d9
- version 155c9b3379
- version 14cf4380c7
- version 138239f418
- version 123f6465c3
- version 11580c106a
- version 10d2ed1573
- version 9767bf2e3
- version 8de5334e9
- version 752b590aa
- version 60ab3e549
- version 5bf08fe5c
- version 458ca27ba
- version 30211f886
- version 2ef051e18
- version 18ac8a0bd
- dev (base)
- latest version5aa3b4dd23 commits,
- version 172fa947f022 commits,
- version 16f9fa25d921 commits,
- version 155c9b337920 commits,
- version 14cf4380c719 commits,
- version 138239f41818 commits,
- version 123f6465c317 commits,
- version 11580c106a16 commits,
- version 10d2ed157315 commits,
- version 9767bf2e313 commits,
- version 8de5334e912 commits,
- version 752b590aa11 commits,
- version 60ab3e54910 commits,
- version 5bf08fe5c9 commits,
- version 458ca27ba8 commits,
- version 30211f8867 commits,
- version 2ef051e186 commits,
- version 18ac8a0bd5 commits,
Compare changes
- Side-by-side
- Inline
Files
5Loading