MAINT: refactor _Messages class
Summary
For caosdb-server#286 (closed)
- rename
_MessagestoMessagessince it is public API - change parent class to list since Multiple Messages with same type and code may occur
- deprecate lots of stuff that makes usage fuzzy (e.g. three different ways to supply arguments) and concentrate on behavior that is close to that of lists (which is what users know)
Focus
It is quite hard to figure out what the current behavior is. However, I preserved it for now and added lots of deprecation warnings.
Test Environment
unit and int test
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen
Merge request reports
Activity
assigned to @henrik
added 39 commits
-
0211f886...e57540dd - 38 commits from branch
dev - 58ca27ba - Merge branch 'dev' into f-messages
-
0211f886...e57540dd - 38 commits from branch
Please register or sign in to reply