TST: Add tests for SELECT updates

Summary

Tests for caosdb-pylib#48 (closed). Ensure that updates of SELECT results can't be conducted. Two of three are still marked as xfail Until caosdb-pylib#48 (closed) and caosdb-server#155 have been resolved

Focus

Tests in tests/test_select.py

Test Environment

Ensure that the test runs through. Maybe remove the xfails to see that these two will fail atm.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

tests/test_select.py

@@ -5,6 +5,8 @@
 #
 # Copyright (C) 2018 Research Group Biomedical Physics,
 # Max-Planck-Institute for Dynamics and Self-Organization Göttingen
+# Copyright (C) 2021 IndiScale GmbH <info@indiscale.com>
+# Copyright (C) 2021 Florian Spreckelsen <f.spreckelsen@indiscale.com>
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License as
@@ -25,6 +27,8 @@
 
 @author: tf
 """
+from pytest import mark, raises
+
 import caosdb as db
 
 
@@ -530,3 +534,45 @@ def test_select_with_subtyping_semantics_and_name_duplicates():
     db.Property(name="TestHousePart", description="This is a duplicate",
                 datatype=db.TEXT).insert(unique=False)
     test_select_with_subtyping_semantics()
+
+
+def test_select_update():
+    """Ensure that the result of a SELECT query can't be used for an
+    update (which might result in data loss).
+
+    """
+    select_result = db.execute_query("SELECT name FROM RECORD TestHouse")[0]
+
+    with raises(db.CaosDBException):
+        select_result.update()
+
+
+@mark.xfail(reason="see pylib issue #48 and server issue #155")
+def test_select_update_with_parent():
+    """Ensure that even with a valid parent, the result of a SELECT query
+    can't be updated.
+
+    """
+
+    test_house_rt = db.RecordType(name="TestHouse").retrieve()
+    select_result = db.execute_query("SELECT name FROM RECORD TestHouse")[0]
+    select_result.add_parent(test_house_rt)
+
+    with raises(db.CaosDBException):
+        select_result.update()
+
+
+@mark.xfail(reason="see pylib issue #48 and server issue #155")
+def test_select_update_with_force():
+    """The update of the result of a SELECT query  may be forced."""
+    test_house_rt = db.RecordType(name="TestHouse").retrieve()
+    select_result = db.execute_query("SELECT name FROM RECORD TestHouse")[0]
+    select_result.add_parent(test_house_rt)
+
+    # TODO: The syntax may change here depending on the implementation
+    # of caosdb-pylib#48
+    select_result.update(force_incomplete=True)
+
+    # only name has been selected and updated, so no properties remain:
+    rec = db.Record(name=select_result.name).retrieve()
+    assert len(rec.properties) == 0