Skip to content
Snippets Groups Projects

TST: Add tests for SELECT updates

Merged Florian Spreckelsen requested to merge f-select-update into dev

Summary

Tests for caosdb-pylib#48 (closed). Ensure that updates of SELECT results can't be conducted. Two of three are still marked as xfail Until caosdb-pylib#48 (closed) and caosdb-server#155 have been resolved

Focus

Tests in tests/test_select.py

Test Environment

Ensure that the test runs through. Maybe remove the xfails to see that these two will fail atm.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #9147 passed

Pipeline passed for e7094cb7 on f-select-update

Merged by Timm FitschenTimm Fitschen 3 years ago (Jun 24, 2021 10:22am UTC)

Loading

Pipeline #9347 passed

Pipeline passed for bdb50342 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading