Final review
Summary
Some additional changes for polishing.
Focus
- Does the Octave interface feel overall usable?
- Do the suggested changes add any additional value?
Test Environment
As usual: make install; make test, or manually with
pkg load caosdb; c = Caosdb(); ent = c.retrieve_by_id("999"){1}; ent.get_properties_as_struct().length.value
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues caosdb/customers/lfpb/management#419 -
Up-to-date CHANGELOG.md (Part of previous announcements) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
TODO
-
set CPPLIB_BRANCH to dev
Merge request reports
Activity
requested review from @timm
added 3 commits
-
20e7548b...91c330e0 - 2 commits from branch
f-doc - 49fb3425 - Merge branch 'f-doc' into f-final-review
-
20e7548b...91c330e0 - 2 commits from branch
added 4 commits
-
49fb3425...3646f297 - 3 commits from branch
f-doc - 4cc683be - Merge branch 'f-doc' into f-final-review
-
49fb3425...3646f297 - 3 commits from branch
added 4 commits
-
4cc683be...c946bae6 - 3 commits from branch
f-doc - 12c0d308 - Merge branch 'f-doc' into f-final-review
-
4cc683be...c946bae6 - 3 commits from branch
added 2 commits
added 4 commits
-
70db2289...84c6ac62 - 2 commits from branch
dev - 47135bcd - Merge branch 'dev' into f-final-review
- 36c5ca0d - Update cpplib dep to v0.0.19
-
70db2289...84c6ac62 - 2 commits from branch
added 2 commits
added 2 commits
added 20 commits
- 7614367f - ENH: src/Makefile is compatible with different tar implementations.
- ff248a9a - ENH: src/configure is compatible with MacOS.
- 992de238 - ENH: Fixed linking on MacOS (and probably on Linux as well).
- 5757cda0 - FIX: Making test/Makefile work on MacOS. For issue #5 (closed)
- be0c8529 - Merge branch 'f-final-review' into f-macos
- a88e6d36 - FIX: Making test/Makefile work better on MacOS. Fixes issue #6 (closed)
- 7dfb24d5 - FIX: Explicit integer size for conversion test. Fixes issue #7 (closed)
- abbec49a - STY: Some style fixes.
- 65c2233b - Merge branch 'dev' into f-macos
- da1870e5 - Merge branch 'f-final-review' into f-macos
- 5b472e5b - DOC: Fixed copyright notice a bit.
- f17a1b9d - ENH: Upgrade dependencies to Debian Buster
- 529919ae - MAINT: Conan version = 1.43, since zlib 1.2.11 requires that version
- c5b0d5b7 - WIP: Pipeline
- 4fa5f5ef - WIP: pipeline
- 98a01c19 - Merge branch 'f-debian-buster' into f-macos
- f9758416 - FIX: Fixed linking order for gcc 10.
- 95a0acf3 - ENH: Unambiguous output for `make test` if successful.
- ddb51df6 - STY: Style fixes.
- d6ad9fff - Merge branch 'f-macos' into f-final-review
Toggle commit listmarked this merge request as draft from c5b0d5b7
added 1 commit
- bac5641f - MAINT: remove unnecessary calls to reset_arena (cpplib)
mentioned in commit c14f34bc