Final review
Summary
Some additional changes for polishing.
Focus
- Does the Octave interface feel overall usable?
- Do the suggested changes add any additional value?
Test Environment
As usual: make install; make test
, or manually with
pkg load caosdb; c = Caosdb(); ent = c.retrieve_by_id("999"){1}; ent.get_properties_as_struct().length.value
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues caosdb/customers/lfpb/management#419 -
Up-to-date CHANGELOG.md (Part of previous announcements) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
TODO
-
set CPPLIB_BRANCH to dev
Edited by Timm Fitschen