Mariadb 10.11: New reserved keyword
-
Review changes -
Open in Workspace
-
-
Download -
Patches
-
Plain diff
Merged
Mariadb 10.11: New reserved keyword
Daniel Hornungrequested to merge
f-mariadb-10.11 into dev
Summary
OFFSET
has become a reserved keyword in MariaDB 10.6, so a parameter name had to be changed.
Focus
Are there any unwanted side effects?
Test Environment
Build and start LinkAhead with this branch.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues caosdb-deploy#356 -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Compare and
- version 17458ccdf7
- version 162563a2e6
- version 156d63bb73
- version 147e1bf2e3
- version 1357046936
- version 120801b110
- version 11c1645216
- version 103e630df1
- version 9382bd4fe
- version 857772ded
- version 76f12b473
- version 6f538e647
- version 52cd39d14
- version 433444028
- version 3c477448e
- version 26ff0ee58
- version 187a5aee2
- dev (base)
- latest version3cb7db2111 commits,
- version 17458ccdf710 commits,
- version 162563a2e610 commits,
- version 156d63bb7310 commits,
- version 147e1bf2e39 commits,
- version 13570469369 commits,
- version 120801b1108 commits,
- version 11c164521613 commits,
- version 103e630df112 commits,
- version 9382bd4fe11 commits,
- version 857772ded10 commits,
- version 76f12b4739 commits,
- version 6f538e6478 commits,
- version 52cd39d147 commits,
- version 4334440286 commits,
- version 3c477448e6 commits,
- version 26ff0ee585 commits,
- version 187a5aee24 commits,
Compare changes
- Side-by-side
- Inline
Files
17Loading