Skip to content
Snippets Groups Projects

Mariadb 10.11: New reserved keyword

Merged Daniel Hornung requested to merge f-mariadb-10.11 into dev

Summary

OFFSET has become a reserved keyword in MariaDB 10.6, so a parameter name had to be changed.

Focus

Are there any unwanted side effects?

Test Environment

Build and start LinkAhead with this branch.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues caosdb-deploy#356
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Pipeline #56129 passed

Pipeline: LinkAhead

#56130

    Pipeline passed for 3cb7db21 on f-mariadb-10.11

    Approval is optional

    Merged by Florian SpreckelsenFlorian Spreckelsen 5 months ago (Oct 9, 2024 3:15pm UTC)

    Merge details

    • Changes merged into with 9d461b7e.
    • Deleted the source branch.

    Pipeline #56685 failed

    Pipeline: LinkAhead

    #56686

      Pipeline failed for 9d461b7e on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      Please register or sign in to reply
      Loading