F release results

Summary

Fixes SegFaults in the retrieve function (and others) which were caused by the too-early deletion of the transaction object by the garbage collector

Focus

The most relevant line is where we call caosdb_transaction_result_set_release_at instead of caosdb_transaction_result_set_at and release the entity from the result set.

Test Environment

Integration caosdb-juliainttest!7 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/Transaction.jl

@@ -444,7 +444,7 @@ result set which is about to be destroyed anyway.
 """
 function _release_result_at(results::Ref{_ResultSet}, index::Cint)
 
-    size = release_result_size(results)
+    size = get_result_size(results)
 
     if index > size
         throw(
@@ -526,7 +526,7 @@ function _release_results(transaction::Ref{_Transaction})
 end
 
 """
-    function _release_results(transaction::Ref{_ResultSet})
+    function _release_results(result_set::Ref{_ResultSet})
 
 Return all entities of the given `result_set`.
 
@@ -534,7 +534,7 @@ This function also leaves the result_set object in a corrupted state and
 should only be used to release the entities from a result_set which is about to
 be destroyed anyway.
 """
-function _release_results(transaction::Ref{_ResultSet})
+function _release_results(result_set::Ref{_ResultSet})
 
     size = get_result_size(result_set)